-
Notifications
You must be signed in to change notification settings - Fork 266
Adding support for Nicolet .e files #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding support for Nicolet .e files #1750
Conversation
|
@h-mayorquin , @zm711 , @samuelgarcia Also, I am already using the module and have discovered some errors and fixed them in my version which I will push on my fork and will be included in this pull request. I think it makes most sense to wait for the responses, and then you can do the code review. |
|
Thanks, please pin us once you have the responses and this is ready for review. |
… segments within the same file
…ple_index, not seconds
|
Dear @zm711 , @h-mayorquin , @samuelgarcia |
Is this ready to be reviewed now?
+1 |
…en"] is corrupted
|
@h-mayorquin , sorry for the delay. Yes, it is ready to be reviewed now. |
The reader for .e files as mentioned in #1510